Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add FlatBuffers using SwiftPM [Swift, macOS, master] #5708

Closed
juliand665 opened this issue Jan 12, 2020 · 4 comments · Fixed by #5771
Closed

Can't add FlatBuffers using SwiftPM [Swift, macOS, master] #5708

juliand665 opened this issue Jan 12, 2020 · 4 comments · Fixed by #5771

Comments

@juliand665
Copy link

Currently, the Package.swift file (to allow swift users to add FlatBuffers via the Swift Package Manager) is nested inside the swift subfolder of the repo. However, the package manager can't work with this:

Packages are Git repositories, tagged with semantic versions, containing a Package.swift file at their root.

So it looks like Package.swift will need to be moved into the root folder (and the paths in it adjusted).

@juliand665
Copy link
Author

Paging @mustiikhalil, the author of #5603

@mustiikhalil
Copy link
Collaborator

mustiikhalil commented Jan 12, 2020

@juliand665 yes we are aware of that

@mzaks Referring to the swift PR:

@aardappel as far as I can tell in order to make subtree work, we need something like following command:

git subtree push --prefix swift origin swift

To create a new branch swift, which contains only the code from swift folder. This branch can be used for releases of Swift Library and also as a URL for Swift Package Manager. We would need to enhance the build and release pipeline though. But then we could use the same technique for Rust, Dart, etc... And move package.json and pom.xml into subfolders.

That will be following in a different PR since the structure of the project will be changing. So that swift will be in its own branch.
@aardappel should I work on making swift its own subtree?

@juliand665
Copy link
Author

Ah, damn. So what's the solution for now? Check out the whole repo and just add the package locally?

@mustiikhalil
Copy link
Collaborator

Yes, that will be the current solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants