You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello again! At the Princeton office, we work on, among other things, optimization algorithms for deep learning. We're interested in using flax and wanted to add some other well-known algorithms. Would you guys be open to reorganizing optim.py into a directory a la pytorch? Happy to submit a PR if so!
Usually, this would accompany a PR, but being new around here, wanted to understand how (if at all) you wanted to reorganize.
One possibility: All subclasses of OptimizerDef (except MultiOptimizer, which appears to have a circular dependency with OptimizerDef) live in their own files (e.g., Momentum, GradientDescent)
The text was updated successfully, but these errors were encountered:
Hello again! At the Princeton office, we work on, among other things, optimization algorithms for deep learning. We're interested in using
flax
and wanted to add some other well-known algorithms. Would you guys be open to reorganizingoptim.py
into a directory a la pytorch? Happy to submit a PR if so!Usually, this would accompany a PR, but being new around here, wanted to understand how (if at all) you wanted to reorganize.
One possibility: All subclasses of
OptimizerDef
(exceptMultiOptimizer
, which appears to have a circular dependency withOptimizerDef
) live in their own files (e.g.,Momentum
,GradientDescent
)The text was updated successfully, but these errors were encountered: