Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing optim into directory structure? #129

Closed
danielsuo opened this issue Mar 27, 2020 · 1 comment
Closed

Reorganizing optim into directory structure? #129

danielsuo opened this issue Mar 27, 2020 · 1 comment

Comments

@danielsuo
Copy link
Collaborator

Hello again! At the Princeton office, we work on, among other things, optimization algorithms for deep learning. We're interested in using flax and wanted to add some other well-known algorithms. Would you guys be open to reorganizing optim.py into a directory a la pytorch? Happy to submit a PR if so!

Usually, this would accompany a PR, but being new around here, wanted to understand how (if at all) you wanted to reorganize.

One possibility: All subclasses of OptimizerDef (except MultiOptimizer, which appears to have a circular dependency with OptimizerDef) live in their own files (e.g., Momentum, GradientDescent)

@jheek
Copy link
Member

jheek commented Mar 30, 2020

Sounds like a great proposal to me! And I agree it would be good to do this refactor before adding many more optimizers

danielsuo added a commit to danielsuo/flax that referenced this issue Mar 30, 2020
levskaya added a commit that referenced this issue Mar 31, 2020
Closes #129: reorganize optim into directory structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants