Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a guide, HOWTO and/or example that shows how to correctly deal with the last batch during eval #1850

Closed
avital opened this issue Feb 3, 2022 · 3 comments
Assignees
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request

Comments

@avital
Copy link
Contributor

avital commented Feb 3, 2022

See #264 for the original motivation -- many naive implementations of eval loop over a full dataset would incorrectly deal with the last batch, that may be smaller than the others, including most of our examples. A fully complete solution would add complexity to the examples, so depending on how educational they are, it may not be the right tradeoff. Instead, we should clearly document in one place the full set of best practices to achieve this, and if needed, add utility functions to Flax to make this easier to do.

@andsteing
Copy link
Collaborator

See also #527 about computing metrics correctly in examples.

@jheek jheek added Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. labels Mar 14, 2022
@andsteing andsteing self-assigned this May 3, 2022
@marcvanzee
Copy link
Collaborator

Closing this in favor of #2116.

@andsteing
Copy link
Collaborator

See also #2111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 - no schedule Best effort response and resolution. We have no plan to work on this at the moment. Status: pull requests welcome We agree with the direction proposed, feel free to give it a shot and file a pull request
Projects
None yet
Development

No branches or pull requests

4 participants