Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] GraphSage with cora|citeseer|pubmed #211

Closed
djdongjin opened this issue Apr 18, 2020 · 4 comments
Closed

[Example] GraphSage with cora|citeseer|pubmed #211

djdongjin opened this issue Apr 18, 2020 · 4 comments

Comments

@djdongjin
Copy link

Currently the GNN model uses a GCN model trained on the Zachary's karate club dataset. However, both the model and the dataset are simplified, e.g., GCN is the most basic GNN layer and the dataset used can be simply represented as an edge_list.

I'd like to write a GraphSage model with one of the titled datasets to concrete the examples under the GNN section.

@avital
Copy link
Contributor

avital commented Apr 24, 2020

Hi! This could be interesting to consider. As a first step, do you have an implementation that's forked from our existing GNN example to demonstrate what that would look like?

We'd be happy to link to that, in parallel to considering if our example should change, or if this could be a HOWTO, or something else.

@djdongjin
Copy link
Author

Not yet, since the contribute guide mentions that for new models an issue should be open first. but will do it shortly as a practice.

@avital
Copy link
Contributor

avital commented Apr 24, 2020 via email

@avital
Copy link
Contributor

avital commented May 12, 2020

Hi @djdongjin! We now have concrete guidance about linking to external example. We'd love to link to your GNN examples when they're ready -- just file a pull request against examples/README.md. You can also learn more about our thinking of official and external examples in that README.

@avital avital closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants