Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vanilla / Elman / simple RNN cell #3681

Closed
carlosgmartin opened this issue Feb 6, 2024 · 4 comments · Fixed by #3697
Closed

Add vanilla / Elman / simple RNN cell #3681

carlosgmartin opened this issue Feb 6, 2024 · 4 comments · Fixed by #3697

Comments

@carlosgmartin
Copy link
Contributor

Add the vanilla / Elman / simple RNN cell to flax.linen.

This is one of the most well-known RNN cells. Torch and keras provide it out-of-the-box:

I can submit a PR for this, if desired.
@cgarciae
Copy link
Collaborator

Hey @carlosgmartin! Happy to review the PR :)

@carlosgmartin
Copy link
Contributor Author

@cgarciae Any preference with respect to naming?

@cgarciae
Copy link
Collaborator

Feel free to pick one, both seem fine :)

@carlosgmartin carlosgmartin mentioned this issue Feb 14, 2024
Merged
@carlosgmartin
Copy link
Contributor Author

@cgarciae #3697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SimpleCell.
2 participants
@cgarciae @carlosgmartin