Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus integration. #191

Closed
bgalehouse opened this issue May 15, 2019 · 3 comments
Closed

Prometheus integration. #191

bgalehouse opened this issue May 15, 2019 · 3 comments

Comments

@bgalehouse
Copy link
Contributor

We should provide a default implementation of stats.Collector
https://github.com/google/fleetspeak/blob/master/fleetspeak/src/server/stats/collector.go
Which integrates with Prometheus.

@tsehori
Copy link
Contributor

tsehori commented Jul 1, 2020

We should export another metric, ingestedPayloadSize, which will be accumulated in MessageIngested. A similar metric exists, messagesSavedSize (it is possible in this case as the parameter savedPayloadBytes is passed from manager.go), but it is not the case when parameters are passed to MessageIngested (neither when it is backlogged and when it is not.

@tsehori
Copy link
Contributor

tsehori commented Aug 5, 2020

@bgalehouse do you think we can resolve this issue, or are there any other enhancements or improvements regarding the Prometheus stats collector?

@mbushkov
Copy link
Collaborator

mbushkov commented Jun 6, 2023

This is resolved now. Prometheus implementation was implemented.

@mbushkov mbushkov closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants