Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests to check that all proto files are generated with the same version #298

Closed
tsehori opened this issue Sep 29, 2020 · 0 comments · Fixed by #300
Closed

Add CI tests to check that all proto files are generated with the same version #298

tsehori opened this issue Sep 29, 2020 · 0 comments · Fixed by #300

Comments

@tsehori
Copy link
Contributor

tsehori commented Sep 29, 2020

We want to deal with the possible inconsistency between versions of protocol buffer generation using protoc-gen-go, as developers that use different versions may hit issues when building and/or testing their Fleetspeak deployments.

To overcome this, we want to add tests to Travis CI that regenerate the proto files using a fixed version of protoc-gen-go and diff them with the generated files in submitted pull requests. This can be done by using git diff that should be accessible through Travis CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant