Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexboxLayout#getFlexLines may include dummy flex lines. #117

Closed
thagikura opened this issue Sep 5, 2016 · 0 comments
Closed

FlexboxLayout#getFlexLines may include dummy flex lines. #117

thagikura opened this issue Sep 5, 2016 · 0 comments
Labels
bug workload low
Milestone
0.3.0

Comments

@thagikura
Copy link
Contributor

thagikura commented Sep 5, 2016 •
edited

FlexboxLayout#getFlexLines may return FlexLines including dummy ones (a FlexLine that doesn't have any flex items in it but used as determining alignment along the cross axis) depending on the alignContent property.

For example, when the alignContent property is set to center dummy flex lines are inserted as the first and the last flex lines.

The dummy flex lines need to be removed from the result of FlexboxLayout#getFlexLines.
thagikura added a commit that referenced this issue Sep 5, 2016
@thagikura
Fixes #117.
706ea27 
Remove dummy flex lines from the result of `FlexLayout#getFlexLines`.

Change-Id: Ife4c3674c98759b899a7458abd17b535b1d0243f
@thagikura thagikura mentioned this issue Sep 5, 2016
Merged
thagikura added a commit that referenced this issue Sep 5, 2016
@thagikura
Fixes #117. (#118)
76331cd 
Remove dummy flex lines from the result of `FlexLayout#getFlexLines`.
@thagikura thagikura added this to the 0.3.0 milestone Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug workload low
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@thagikura