Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid sizing of child when it has no size but only flexGrow #139

Closed
andrey-shikhov opened this issue Nov 15, 2016 · 2 comments
Closed
Labels
Milestone

Comments

@andrey-shikhov
Copy link

Android snippet:
https://gist.github.com/andrey-shikhov/6f65ca14bf3d44f0393a0f8ba6b9b764

screenshot_1479233115

Css snippet:
https://gist.github.com/andrey-shikhov/78d24b0724b1cc5f5690c2aa3597ddab

css-screen

A Very weird behavior of children measuring when a child has only flexGrow value without width. In this example, android flexbox gives height to child equal to count of chars int text(child of child in flexbox).
It really different from css flexbox(css snippet above)

@thagikura thagikura added the bug label Nov 16, 2016
@thagikura
Copy link
Contributor

Thanks for the report.

It looks like the height of the text views are calculated with its width set to 0 at first, so the height of those are expanded as the text length is increased.

Anyway I'll fix this.

Thanks!

@thagikura
Copy link
Contributor

Fixed by #140. I'll release the new version of the library shortly (with other bug fixes).

@thagikura thagikura added this to the 0.2.4 milestone Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants