Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mOrderCache's value is never changed #266

Closed
thetran84 opened this issue Apr 18, 2017 · 4 comments
Closed

mOrderCache's value is never changed #266

thetran84 opened this issue Apr 18, 2017 · 4 comments
Labels
Milestone

Comments

@thetran84
Copy link

thetran84 commented Apr 18, 2017

mOrderCache is supposed to store the previous order of all childView, but its value is never changed at runtime when I tried to swap the order of 2 childViews.
In file FlexboxLayout.java, line 472, I tried to change it like this and it fixed the issue.
mOrderCache.append(order.index, order.order);

@thetran84 thetran84 changed the title mOrderCache mOrderCache's value is never changed Apr 18, 2017
@thagikura
Copy link
Contributor

Thanks!
You are right. The line 472 should be
mOrderCache.append(order.index, order.order);

I'm going to fix it.

@thagikura thagikura added the bug label Apr 18, 2017
@thagikura
Copy link
Contributor

Fixed by #267

@thagikura thagikura added this to the 0.2.7 milestone Apr 18, 2017
@thetran84
Copy link
Author

When can I expect to get the version 0.2.7 released?

@thagikura
Copy link
Contributor

Not too long. Looks like there are no other pending issues.
Thanks for poking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants