Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_no_implicit_file_export will break Flogger in a future Bazel release #124

Closed
bazel-flag-bot opened this issue Dec 26, 2019 · 1 comment

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_no_implicit_file_export will be enabled by default in a future Bazel release [1], thus breaking Flogger.

The flag is documented here: bazelbuild/bazel#10225

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.

If you don't want to receive any future issues for Flogger or if you have any questions,
please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.

[1] The target release hasn't been determined yet. Our tool will update the issue title once the flag flip has been scheduled.

@cpovirk
Copy link
Member

cpovirk commented Dec 27, 2019

(20:22:43) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/11e901125f13327934febaa92e1e92f1/external/bazel_tools/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/BUILD:4:1: in java_import rule @bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:all_lcov_merger_lib: target '@remote_coverage_tools//:all_lcov_merger_tools_deploy.jar' is not visible from target '@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:all_lcov_merger_lib'. Check the visibility declaration of the former target if you think the dependency is legitimate

It sounds like there is a chance that this is a problem in Bazel itself, though it's not completely clear to me: bazelbuild/continuous-integration#887 (There's also some discussion on bazelbuild/bazel#10225 and bazelbuild/continuous-integration#891)

I'm going to optimistically close this bug, but I'll subscribe to those 3 bugs in case there are updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants