Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log4j backend #4

Closed
EdwinKempin opened this issue Apr 19, 2018 · 9 comments
Closed

Add log4j backend #4

EdwinKempin opened this issue Apr 19, 2018 · 9 comments

Comments

@EdwinKempin
Copy link
Contributor

We want to use Flogger in Gerrit where we currently use slf4j with a log4j backend. We want to continue using log4j as backend so that the switch to Flogger is transparent for existing Gerrit installations and existing log4j configurations continue to work.

@EdwinKempin
Copy link
Contributor Author

You can assign this issue to me. I'm already looking at ways to implement this.

@cslee00
Copy link
Contributor

cslee00 commented Apr 23, 2018

Started this for logback: https://github.com/cslee00/digitalascent-flogger-logback, working through how to drop it into Flogger

@ben-manes
Copy link

Would there be much harm in having an slf4j backend?

@Bananeweizen
Copy link

@ben-manes Do I get it right that you suggest chaining flogger to slf4j to any of the logging frameworks underneath? In a sense that this would be more flexible than the suggest log4j-only implementation? If so, I'm +1. :)

@cslee00
Copy link
Contributor

cslee00 commented Apr 27, 2018

Clunky to chain together two logging APIs (flogger, slf4j) - there are overlaps in responsibilities as they both provide a facade on back-end logging implemementations. Cleanest from an implementation & performance perspective to use back-end loggers directly.

@EdwinKempin
Copy link
Contributor Author

This got merged now:
#23

@davido
Copy link

davido commented May 15, 2018

What about log4j2 backend? There are these CLs pending for review for Gerrit: [1] and many other distros, e.g. ElasticSearch (that Gerrit currently depends on) already migrated to log4j2.

[1] https://gerrit-review.googlesource.com/#/q/topic:update-log4j-to-log4j2

@EdwinKempin
Copy link
Contributor Author

I think writing a backend for log4j2 would be straight-forward now that we have one for log4j, but it's nothing I'm planning to look at.

@paladox
Copy link
Contributor

paladox commented May 22, 2018

Though log4j2 syntax is significantly different to log4j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants