Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using internal system channel for text input handling #47

Closed
stuartmorgan opened this issue Apr 24, 2018 · 4 comments
Closed

Stop using internal system channel for text input handling #47

stuartmorgan opened this issue Apr 24, 2018 · 4 comments

Comments

@stuartmorgan
Copy link
Collaborator

The current text input plugin is based on implementation details of the engine that are not public/stable API. Once there's a clearly defined text input API for embedders we need to switch to using that instead of the current unsupported approach.

@krisgiesing
Copy link
Contributor

Can you elaborate on which specific implementation details of the engine are relevant?

@stuartmorgan
Copy link
Collaborator Author

stuartmorgan commented Apr 24, 2018

My understanding is essentially everything in the text input system as currently implemented: the platform channel names of the messages the plugin handles, the keys and structures in the response objects, and in general the whole concept of implementing text input through the generic platform messaging system rather than a formal API.

@krisgiesing
Copy link
Contributor

krisgiesing commented Apr 24, 2018

Ah, I think you mean "framework" then rather than "engine"? That is, these are Dart code constructs we're referencing, not C/C++ code constructs.

@stuartmorgan
Copy link
Collaborator Author

Closing; this is a non-issue now that the shells are part of flutter/engine. (There should probably still be a solution to this for other embedders, but that's no longer in scope for the desktop work.)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Overview Kanban
  
Awaiting Flutter Support
Development

No branches or pull requests

2 participants