Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menubar] Plugin does not print Errors #551

Open
shyndman opened this issue Sep 10, 2019 · 1 comment
Open

[menubar] Plugin does not print Errors #551

shyndman opened this issue Sep 10, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@shyndman
Copy link

Hi there,

The menubar plugin handles Exceptions by printing them, but subclasses of Errors slip through the cracks and go unprinted. This is a result of this catch.

Perhaps a fallback catch is warranted, with a print and a rethrow?

@stuartmorgan
Copy link
Collaborator

I think that was actually a workaround for the fact that we couldn't get responses from native->Dart calls, which has since been fixed; that structure should be revisited. We should see if error conditions get returned at the platform channel level now.

@stuartmorgan stuartmorgan added bug Something isn't working plugin labels Mar 5, 2020
@stuartmorgan stuartmorgan changed the title menubar plugin does not print Errors [menubar] Plugin does not print Errors Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants