Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_flutter_engine fails with a clean Flutter tree #63

Closed
stuartmorgan opened this issue May 30, 2018 · 0 comments
Closed

update_flutter_engine fails with a clean Flutter tree #63

stuartmorgan opened this issue May 30, 2018 · 0 comments
Assignees
@stuartmorgan

Comments

@stuartmorgan
Copy link
Collaborator

A fresh Flutter tree checkout doesn't have the dart binary it in, since it's fetched on demand. The wrapper script will need to run some minimal flutter command to fetch it (I'm not sure yet what the best option is).
@stuartmorgan stuartmorgan self-assigned this May 30, 2018
stuartmorgan added a commit to stuartmorgan/flutter-desktop-embedding that referenced this issue May 31, 2018
@stuartmorgan
Ensure Dart is present in update_flutter_engine
5eb0899 
A clean Flutter doesn't contain Dart; check whether Dart is present
before trying to use it, and if not run 'flutter precache'.

Fixes issue google#63
@stuartmorgan stuartmorgan mentioned this issue May 31, 2018
Merged
awdavies pushed a commit that referenced this issue May 31, 2018
@stuartmorgan @awdavies
Ensure Dart is present in update_flutter_engine (#64)
0738534 
A clean Flutter doesn't contain Dart; check whether Dart is present
before trying to use it, and if not run 'flutter precache'.

Fixes issue #63
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartmorgan