Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crimson Text - Line Height Issue #2395

Closed
sara-wong opened this issue Mar 18, 2020 · 4 comments · Fixed by #4416
Closed

Crimson Text - Line Height Issue #2395

sara-wong opened this issue Mar 18, 2020 · 4 comments · Fixed by #4416

Comments

@sara-wong
Copy link

We are currently using, https://fonts.google.com/specimen/Crimson+Text, but are running into a bolding issue. When a text is bolded in a body paragraph, the line-height of the row of text is higher. Bold and Regular text styles should be the same line-height. We've done an investigation into this problem and it seems like the root of the cause is the font file itself.

three

@davelab6
Copy link
Member

Thanks! This should be a problem we can automatically identify using FontBakery's existing vertical metrics checks. @felipesanches to confirm :)

@davelab6 davelab6 added this to the Bugs in Font Files 02 Requires Hotfixing milestone Mar 18, 2020
@felipesanches
Copy link
Collaborator

yes, indeed!

Screenshot from 2020-03-18 00-50-47

@thlinard
Copy link
Contributor

Maybe use Crimson Pro? After all, that's what it was created for: fixing all of Crimson Text's design issues.

@bludrop
Copy link

bludrop commented May 20, 2020

This happens when both bolding and italics. Usually, I end up manually adjusting the paragraph spacing when I have lots of bold or italics, but that's not really an ideal solution.

Crimson Pro is good, but it has too many changes from the original Crimson Text. Post-release of Crimson Pro there was supposed to be a small tweak to Crimson Text to fix stuff like this, but I don't think it happened yet. (it was being discussed in the Google Group)

@RosaWagner RosaWagner removed this from the Bugs in Font Files 02 Requires Hotfixing milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants