Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Serif Pro v 2.000 #602

Closed
frankrolf opened this issue Jan 24, 2017 · 9 comments
Closed

Source Serif Pro v 2.000 #602

frankrolf opened this issue Jan 24, 2017 · 9 comments
Assignees

Comments

@frankrolf
Copy link
Contributor

GWF’s version of Source Serif has not been updated since 2014. In the meantime, it has gained more weights & and broader language support. Find the latest files (ttf & much more) here:

https://github.com/adobe-fonts/source-serif-pro/releases/tag/2.000R

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 24, 2017

Thanks @frankrolf,

I've been working on it this week. Hopefully, I'll send off asap.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 25, 2017

@frankrolf Awesome quality, I'm super happy and impressed by this.

@davelab6 only thing I can see which is a little off is the copyright string. However, the details are in there, no ascii chars, url reference, and proper formatting of RFN. Can I push this without amending this?

Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 25, 2017

@davelab6 @frankrolf On further inspection, the ofl and copyright string match the previous version exactly, https://github.com/google/fonts/blob/master/ofl/sourceserifpro/OFL.txt#L1. No change needed.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 25, 2017

@frankrolf

It appears the vertical metrics have changed a little since our previously hosted version, v1.000.

OS X Safari:
screen shot 2017-01-25 at 10 42 54

Win7 Chrome:
screen shot 2017-01-25 at 10 51 45

I don't have a problem with it in this instance. I'd only be concerned if it produced clipping in Windows platforms, which is doesn't.

@davelab6
Copy link
Member

I think this metrics (and weight) shift is fine

@davelab6 davelab6 added this to the Update Families milestone Jan 25, 2017
@davelab6
Copy link
Member

Related to #82

@frankrolf
Copy link
Contributor Author

Thanks, all!
The shift in vertical metrics was necessary for Vietnamese – and to avoid clipping of the latter on Windows.

About the weight change: Quite early in the project, it was decided that the three styles were too close in weight, so I increased the gamut, only keeping the Regular style where it was. As a result, Semibold and Bold got heavier. See also https://github.com/adobe-fonts/source-serif-pro/releases/tag/1.017R or https://blog.typekit.com/2014/12/11/source-serif-update-three-new-weights/

I don’t know why this change never made it on GWF, the process was different back in the day – glad to see it simplified!

@frankrolf
Copy link
Contributor Author

I noticed that all Roman styles of Source Serif are now available at https://github.com/google/fonts/tree/master/ofl/sourceserifpro, however not at https://fonts.google.com/specimen/Source+Serif+Pro . What needs to be done to update the browse UI?

@davelab6
Copy link
Member

davelab6 commented Dec 2, 2018

Closing as duplicate of #23

@davelab6 davelab6 closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants