Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Fruit's exported symbols #30

Open
poletti-marco opened this issue Oct 16, 2016 · 2 comments
Open

Annotate Fruit's exported symbols #30

poletti-marco opened this issue Oct 16, 2016 · 2 comments
Projects
Milestone

Comments

@poletti-marco
Copy link
Contributor

poletti-marco commented Oct 16, 2016

If Fruit is compiled normally, without using -fvisibility=hidden and then used in client code compiled with -fvisibility=hidden switch, the resulting executable segfaults (this issue was reported by Christoph Duelli).
Ideally, Fruit should support client code that uses -fvisibility=hidden.

Once -fvisibility=hidden is supported, it might be worth also using it when compiling Fruit itself, potentially reducing the compiled size.

@poletti-marco poletti-marco added this to the Fruit 2.1.0 milestone Oct 16, 2016
@poletti-marco poletti-marco removed this from the Fruit 2.1.0 milestone Nov 20, 2016
@poletti-marco
Copy link
Contributor Author

Now that Fruit supports MSVC, this is required to support building Fruit as a dll with MSVC.

@poletti-marco poletti-marco added this to the Fruit 2.1.0 milestone Mar 19, 2017
@poletti-marco poletti-marco changed the title Support GCC/Clang's -fvisibility=hidden Annotate Fruit's exported symbols Mar 19, 2017
@poletti-marco
Copy link
Contributor Author

Now that Fruit supports MSVC, this is required to support building Fruit as a dll with MSVC.

Actually I was wrong, I've now added support for building Fruit as a dll using MSVC with CMake's WINDOWS_EXPORT_ALL_SYMBOLS. So this is no longer blocking full MSVC support.

@poletti-marco poletti-marco removed this from the Fruit 2.1.0 milestone Mar 19, 2017
@poletti-marco poletti-marco added this to the Fruit 2.1.1 milestone Apr 8, 2017
@poletti-marco poletti-marco modified the milestones: 3.1.0, Fruit 2.1.1 Jul 15, 2017
@poletti-marco poletti-marco added this to Low priority in Fruit 3.x Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Fruit 3.x
Low priority
Development

No branches or pull requests

1 participant