Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkit only? #1

Open
linquize opened this issue Jun 28, 2016 · 8 comments · Fixed by #2
Open

webkit only? #1

linquize opened this issue Jun 28, 2016 · 8 comments · Fixed by #2

Comments

@linquize
Copy link

Currently it works only on webkit-based browser such as Chrome.
Firefox, IE, Edge do not work.
This is because Polymer is used.
@ojarjur
Copy link
Collaborator

ojarjur commented Jun 28, 2016

I'll admit that we may have issues with older browsers ( Polymer only claims to support the latest two versions of every major browser ).

However, If you are seeing an issue with other browsers, then it's more likely my fault rather than Polymer.

That's because I have not tested it on any browser but Chrome, so I may have done something stupid that breaks other browsers.

Regardless, I'll try it out on some other browsers as soon as I can get a hold of them.

Thanks for bringing this to my attention.

@MichaelMure
Copy link

The body has a computed height of 0px, so a blank page is shown.

@ojarjur ojarjur mentioned this issue Jun 29, 2016
Merged
@ojarjur
Copy link
Collaborator

ojarjur commented Jun 29, 2016

A quick update: I haven't gotten a chance to test on Edge or Safari yet, but opening the UI in Firefox showed that I had done something stupid.

Specifically, I was using the polyfills library to try to support browsers that don't yet natively support Polymer, but I was not using it correctly. I had the link to load that library but was not waiting until it was ready before trying to register my Polymer components.

#2 fixes that, and I've updated the demo site to use the new code.

Thanks again for pointing this out, and if you see any more compatibility issues, then please let me know.

ojarjur added a commit that referenced this issue Jun 29, 2016
@ojarjur
Submitting review b951d29
032e35d 
Fix a bug in the support for browsers requiring polyfills.

The web UI requires web-components in order work, and not all
browsers support them fully yet. This was supposed to be worked
around by using the 'webcomponents-lite.min.js' library, but
that work-around was not properly implemented.

Specifically, there was no sequencing of the calls to the
'Polymer' function to ensure that they happened after the
web components library was loaded. The result was that the
'Polymer' function would be called before the web components
library was loaded, that name would not yet be defined, and
as a result the UI would completely fail to load.

This change fixes that by not allowing the initial calls to
the 'Polymer' function to happen until after the web components
library has finished loading.

This fixes #1... or, at least, makes the UI work in the latest version of Firefox (I haven't tested Edge or Safari yet).
@ojarjur ojarjur reopened this Jun 29, 2016
@ojarjur
Copy link
Collaborator

ojarjur commented Jun 29, 2016

I'm keeping this open until I can confirm it works in the other browsers (at least Safari and Edge).

@linquize
Copy link
Author

With #2, Edge works. IE11 repo list ok, but review open list and review close list are empty.

@ojarjur
Copy link
Collaborator

ojarjur commented Jun 30, 2016

@linquize Thanks for checking and for catching that issue with IE11.

I looked and it turns out that I had missed one spot (in the review lists) where I needed to make sure the webcomponents library was loaded before the polymer components were used.

That bug will be fixed with #3 (and I've already updated the demo to incorporate that fix).

@linquize
Copy link
Author

#3 reviews.html still not work with IE11.

@ojarjur
Copy link
Collaborator

ojarjur commented Jul 1, 2016

@linquize Thanks for following up and reporting that.

I'll still submit #3 since it is fixing a bug, but I'll leave this open until I can get a hold of an instance of IE11, and can dig into what is going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug in the support for browsers requiring polyfills. google/git-appraise-web
3 participants
@MichaelMure @linquize @ojarjur