Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Don't comment if author has OWNERS #25

Closed
cramforce opened this issue Mar 16, 2017 · 4 comments
Closed

Don't comment if author has OWNERS #25

cramforce opened this issue Mar 16, 2017 · 4 comments
Labels
P1: High Priority Type: Bug
Milestone
critical-0.1.0-rc

Comments

@cramforce
Copy link

See e.g. ampproject/amphtml#8175

I do not need any extra approvals. In that case the bot should not comment.
@cramforce
Copy link
Author

Ah, maybe there is a different bug: The bot says I'm missing full approvals.

@erwinmombay
Copy link
Contributor

erwinmombay commented Mar 16, 2017 •
edited
Loading

yeah, this is a bug. the problem is that it stops at that levels owners (src/OWNERS.yaml). it should really see that you are a root level owner. even though you arent on the list of reviewers that it posts. this is 2nd top priority bug/feature after file level owner.

@erwinmombay
Copy link
Contributor

need to add isInAcestorOwners check when evaluating areAllApprovalsMet

@erwinmombay erwinmombay added this to the critical-1.0 milestone Mar 16, 2017
@erwinmombay
Copy link
Contributor

comment system is obsolete since github now has approvals api

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1: High Priority Type: Bug
Projects
None yet
Milestone
critical-0.1.0-rc
Development

No branches or pull requests
2 participants
@cramforce @erwinmombay