Replace prettify.js

[spearce]

Originally reported on Google Code with ID 6

[Condensed from discussion on a different bug tracker.]

dborowitz:
> I don't think prettify.js supports [deep linking to line number fragments]

sop:
It doesn't, that is why we don't have this feature. I wanted to add it
but it wasn't easy, so I punted.  :-)

dborowitz:
> so we'd either need to add it upstream or switch our prettification engine. We might
be able to hack in some <a> tags in the output we throw in the <pre>, but I don't know
how that will interact with prettify.

sop:
Uhm, you should look at what project hosting does... and not do that.
They run prettify.js, and then run another JavaScript that
post-processes the pretty.js output in order to reformat the HTML to
get anchors at each line, and reformat the whole thing into a table.
Actually this is similar to what Gerrit Code Review does too, but I
think the way Gerrit does this is only slightly less hacky. We don't
rely on a timer polling the window to see when prettify.js is done,
and then run twice.

I was leaning towards switching to Jgments and doing the formatting at
the server side, but [our internal] build is broken.... Formatting on the server side
will also bloat the response side significantly, but its what all of
the cool kids do (GitHub, ...).

Someone pointed out another JavaScript based formatter recently, but
it doesn't look to be nearly as pluggable as prettify.js is. It only
applies on <pre> blocks already in the DOM like prettify, you can't
call it and steal its output the way Gerrit does.

Reported by None on 2012-11-11 15:28:25

[spearce]

[Condensed from discussion on a different bug tracker.]

dborowitz:
> I don't think prettify.js supports [deep linking to line number fragments]

sop:
It doesn't, that is why we don't have this feature. I wanted to add it
but it wasn't easy, so I punted.  :-)

dborowitz:
> so we'd either need to add it upstream or switch our prettification engine. We might
be able to hack in some <a> tags in the output we throw in the <pre>, but I don't know
how that will interact with prettify.

sop:
Uhm, you should look at what project hosting does... and not do that.
They run prettify.js, and then run another JavaScript that
post-processes the pretty.js output in order to reformat the HTML to
get anchors at each line, and reformat the whole thing into a table.
Actually this is similar to what Gerrit Code Review does too, but I
think the way Gerrit does this is only slightly less hacky. We don't
rely on a timer polling the window to see when prettify.js is done,
and then run twice.

I was leaning towards switching to Jgments and doing the formatting at
the server side, but [our internal] build is broken.... Formatting on the server side
will also bloat the response side significantly, but its what all of
the cool kids do (GitHub, ...).

Someone pointed out another JavaScript based formatter recently, but
it doesn't look to be nearly as pluggable as prettify.js is. It only
applies on <pre> blocks already in the DOM like prettify, you can't
call it and steal its output the way Gerrit does.

Reported by None on 2012-11-11 15:28:25

[spearce]

Comment deleted

Reported by None on 2014-07-15 12:58:22

[spearce]

https://gerrit-review.googlesource.com/56453

Reported by None on 2014-07-15 13:02:41