Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action DomainJoin Error #210

Closed
leo-6C656F opened this issue Aug 28, 2020 · 1 comment · Fixed by #211
Closed

Action DomainJoin Error #210

leo-6C656F opened this issue Aug 28, 2020 · 1 comment · Fixed by #211
Assignees
Labels

Comments

@leo-6C656F
Copy link

Hello,

When I try to use the action DomainJoin it fails to join, error below. I think the issue is the powershell command it's executing to join the domain, it is not encompassing the ou in a string.

Action command I'm using
DomainJoin: ['interactive', 'domain.local', 'OU=Laptops,OU=CA,OU=Corporate,DC=domain,DC=local']

image

I found a workaround by changing line 116 in domain_join.py

cmd += ['-OUPath', f'"{self._domain_ou}"']

Do you know if there's an issue with the domain_join.py file or if I'm using the action command incorrectly?

cmd += ['-OUPath', self._domain_ou]

@TsekNet TsekNet self-assigned this Aug 31, 2020
@TsekNet
Copy link
Contributor

TsekNet commented Aug 31, 2020

Will look into this today.

@TsekNet TsekNet added the bug label Aug 31, 2020
@TsekNet TsekNet linked a pull request Aug 31, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants