Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glome-login refers to a mysterious "embedded" service key #33

Closed
delroth opened this issue Aug 5, 2020 · 2 comments
Closed

glome-login refers to a mysterious "embedded" service key #33

delroth opened this issue Aug 5, 2020 · 2 comments
Assignees

Comments

@delroth
Copy link
Contributor

delroth commented Aug 5, 2020

In glome-login --help I spotted the following:

 -k KEY    use KEY as the hex-encoded service key (defaults to the embedded key)

I can't seem to find any reference to what this embedded key is and where it lives, and from looking at the source code I suspect it might not exist. Could you clarify the documentation and/or remove this?

@bluecmd
Copy link
Contributor

bluecmd commented Aug 5, 2020

Internally we do not use a config file, we instead call login_run straight away with hardcoded public keys - that's where the awkward description comes from.

Right now -k is parsed before config is read, so the config file takes precedence - which is a bit odd.

I'd suggest we:

  • Change the description of -k to say .. (defaults to key from configuration)
  • Change that -k overrides the key possibly present in the configuration file

@burgerdev
Copy link
Collaborator

The last occurrence I knew of has been removed in #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants