Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"meson install" tries to install an example config with a default service key #34

Closed
delroth opened this issue Aug 5, 2020 · 1 comment · Fixed by #36 or #38
Closed

"meson install" tries to install an example config with a default service key #34

delroth opened this issue Aug 5, 2020 · 1 comment · Fixed by #36 or #38

Comments

@delroth
Copy link
Contributor

delroth commented Aug 5, 2020

When running "meson install", the build system installs example.cfg as the default configuration. Since example.cfg is a working config file with a hardcoded key, this seems like a dangerous behavior.

Luckily, it happens that a bug makes this harmless right now: meson installs to ${sysconfdir}/config while glome-login attempts to look up the config in ${sysconfdir}/glome/config. I suspect this is however not deliberate :-)

@pkern pkern linked a pull request Aug 5, 2020 that will close this issue
@pkern
Copy link
Member

pkern commented Aug 5, 2020

The latter is addressed by #36. #28 talks about improving the whole config setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants