Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: automatically instrument with metrics using ocsql #1172

Closed
zombiezen opened this issue Jan 24, 2019 · 1 comment
Closed

sql: automatically instrument with metrics using ocsql #1172

zombiezen opened this issue Jan 24, 2019 · 1 comment
Assignees
@jba
Labels
enhancement New feature or request

Comments

@zombiezen
Copy link
Contributor

ocsql now supports automatically collecting *sql.DB metrics using the RecordStats function. Seems like we should add this in. The integration guide has an example of how to do this.

(Assigning @jba who's looking into metrics across Go Cloud right now as part of #1130. Please milestone as appropriate.)
@zombiezen zombiezen added the enhancement New feature or request label Jan 24, 2019
@zombiezen zombiezen mentioned this issue Jan 24, 2019
Merged
@jba jba added this to the Sprint 22 milestone Jan 24, 2019
@vangent vangent modified the milestones: Sprint 22, Sprint 23 Feb 11, 2019
@vangent vangent removed this from the Sprint 23 milestone Mar 1, 2019
@zombiezen
Copy link
Contributor Author

Done as part of work for #1175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jba jba

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zombiezen @jba @vangent