Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstore/driver: Tests fail on 32 bits arches #2675

Closed
eclipseo opened this issue Sep 23, 2019 · 5 comments · Fixed by #2678
Closed

docstore/driver: Tests fail on 32 bits arches #2675

eclipseo opened this issue Sep 23, 2019 · 5 comments · Fixed by #2678
Assignees
Labels
needs info Further discussion or clarification is necessary

Comments

@eclipseo
Copy link

eclipseo commented Sep 23, 2019

With Go 1.13 on i686 and armv7hl, gocloud 0.17.0:

gocloud.dev/docstore/driver
# gocloud.dev/docstore/driver [gocloud.dev/docstore/driver.test]
./compare_test.go:75:8: constant 9223372036854775807 overflows int
./compare_test.go:78:8: constant 9223372036854775807 overflows int
./compare_test.go:78:33: constant 9223372036854775806 overflows int
./compare_test.go:79:8: constant 9223372036854775807 overflows int
./compare_test.go:80:8: constant 9223372036854775807 overflows int
./compare_test.go:83:8: constant 9223372036854775807 overflows int
./compare_test.go:84:8: constant -9223372036854775808 overflows int
FAIL	gocloud.dev/docstore/driver [build failed]
@vangent
Copy link
Contributor

vangent commented Sep 24, 2019

@eclipseo , could you patch the PR and see if that fixes it?

@eliben
Copy link
Member

eliben commented Oct 8, 2019

@eclipseo could you please test the fix in #2678?

If you no longer care about this issue, please let us know and we'll close it.

@eliben eliben added the needs info Further discussion or clarification is necessary label Oct 8, 2019
@QuLogic
Copy link

QuLogic commented Oct 16, 2019

There is another failure after applying the above patch:

gocloud.dev/docstore/gcpfirestore
# gocloud.dev/docstore/gcpfirestore [gocloud.dev/docstore/gcpfirestore.test]
./query_test.go:153:3: constant 9223372036854775807 overflows int
FAIL	gocloud.dev/docstore/gcpfirestore [build failed]

@QuLogic
Copy link

QuLogic commented Oct 16, 2019

Applying a similar patch to that last file works on armv7hl and i686.

@vangent
Copy link
Contributor

vangent commented Oct 17, 2019

OK, I updated the PR with a fix for gcpfirestore/query_test.go:153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info Further discussion or clarification is necessary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants