Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob/fileblob: Make it possible to set the permissions used in CreateDir #3423

Closed
stanhu opened this issue Apr 23, 2024 · 0 comments · Fixed by #3426
Closed

blob/fileblob: Make it possible to set the permissions used in CreateDir #3423

stanhu opened this issue Apr 23, 2024 · 0 comments · Fixed by #3426

Comments

@stanhu
Copy link
Contributor

stanhu commented Apr 23, 2024 •
edited

Is your feature request related to a problem? Please describe.

Currently fileblob sets the permissions to 0777:

go-cloud/blob/fileblob/fileblob.go

Line 268 in be1b4ae

err = os.MkdirAll(absdir, os.FileMode(0777))

We use fileblob to store backups, and we'd prefer this not be world-readable. We'd like to lock this down and use perm.PrivateDir or 0700. It'd be nice to make that the default or make it configurable.

For now, we'll just use os.MkdirAll ourselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

blob/fileblob: Allow customization of the FileMode vangent/go-cloud
1 participant
@stanhu