New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example test building seems to sneak past Travis #56

Closed

cflewis opened this issue May 31, 2018 · 1 comment

Labels

bug code health

Milestone

Contributor

cflewis commented May 31, 2018

There are some example tests that don't build. Somehow they got through Travis which is odd.

$ go test -run=TestWatchReplay runtimevar/runtimeconfigurator/*.go
# command-line-arguments_test
runtimevar/runtimeconfigurator/example_test.go:32:24: undefined: runtimeconfigurator.Dial
runtimevar/runtimeconfigurator/example_test.go:37:41: multiple-value runtimeconfigurator.NewClient() in single-value context
FAIL	command-line-arguments [build failed]

cflewis added this to the Sprint 13 milestone

cflewis added bug code health labels

Contributor Author

cflewis commented May 31, 2018

PEBKAC: need vgo not go. I am a bad person.

cflewis closed this as completed

zombiezen modified the milestones: Sprint 13, Sprint 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment