Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure k8schain imports #1042

Open
jonjohnsonjr opened this issue Jun 9, 2021 · 3 comments
Open

Restructure k8schain imports #1042

jonjohnsonjr opened this issue Jun 9, 2021 · 3 comments
Labels
lifecycle/frozen

Comments

@jonjohnsonjr
Copy link
Collaborator

We do side-effectual imports in k8schain to pull in cloud-specific credential providers. We currently have build tags to disable importing specific things in k8schain. This seems backwards.

Callers should be responsible for importing these magic packages, not k8schain, which would make the dependency graph a little less stupid.
@jonjohnsonjr
Copy link
Collaborator Author

@dprotaso @hasheddan WDYT

@dprotaso
Copy link
Contributor

dprotaso commented Jun 9, 2021

Yeah I agree - this could be coupled with adoption of the new k8s cloud provider libs

@jonjohnsonjr jonjohnsonjr mentioned this issue Jun 15, 2021
Merged
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@hugoShaka hugoShaka mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dprotaso @jonjohnsonjr