regenerate protos #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googleapis 730ae385e8ddae8672c3d0fcbd3554d524456319 protobuf v3.4.0
|
@jba This commit adds firestore/admin files. We didn't add this before, but I believe adding it here is OK. We'll continue to not generate GAPIC client for it. Please let me know if you disagree. |
|
https://code-review.googlesource.com/#/c/gocloud/+/19090/ should land first |
jba
approved these changes
Oct 31, 2017
gopherbot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
Nov 1, 2017
googleapis: 730ae385e8ddae8672c3d0fcbd3554d524456319 Require googleapis/go-genproto#41 Change-Id: Id928e4ad84512ee02f3c22ca14e8a52da4d24f20 Reviewed-on: https://code-review.googlesource.com/19091 Reviewed-by: Jonathan Amsterdam <jba@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
googleapis 730ae385e8ddae8672c3d0fcbd3554d524456319
protobuf v3.4.0