Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListOptions pagination for Dependabot alerts #2853

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

jporzucek
Copy link
Contributor

@jporzucek jporzucek commented Aug 1, 2023

Fixes 2852

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2853 (3c2420f) into master (f897b2c) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         138      138           
  Lines       12318    12327    +9     
=======================================
+ Hits        12080    12089    +9     
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/dependabot_alerts.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). waiting for reply labels Aug 1, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 2, 2023

Please see feedback here: #2852 (comment)

@jporzucek jporzucek changed the title Switch to ListOptions pagination for Dependabot alerts Add ListOptions pagination for Dependabot alerts Aug 8, 2023
@gmlewis gmlewis removed waiting for reply Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Aug 8, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !
LGTM.
Merging.

@gmlewis gmlewis merged commit 899235e into google:master Aug 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Dependabot alerts endpoint stopped supporting cursor pagination
2 participants