Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing field important to find branch in fork from same owner #2873

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

r-aramizu
Copy link
Contributor

@r-aramizu r-aramizu commented Aug 15, 2023

Hello there! I opened an issue to explain this suggestion.

I put the new field on your tests and keep working as before! There was a change that could solve my problem!

Fixes: #2872.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @r-aramizu !
Please run go generate ./... in the top of the repo and then push (not force-push) the changes to this same PR, and that should fix the tests.
See CONTRIBUTING.md for more information.

@google-cla
Copy link

google-cla bot commented Aug 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@r-aramizu
Copy link
Contributor Author

r-aramizu commented Aug 15, 2023

Thank you @gmlewis ! My bad for forget this 😅
Done!

@r-aramizu r-aramizu requested a review from gmlewis August 15, 2023 18:12
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

@r-aramizu - please follow the CLA instructions from the comment above:
#2873 (comment)
in order to sign the Google CLA. Thank you!

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2873 (263a3f3) into master (352e4c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2873   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         139      139           
  Lines       12357    12357           
=======================================
  Hits        12119    12119           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/pulls.go 96.77% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @r-aramizu !
LGTM.
Merging.

@gmlewis gmlewis merged commit 0c10d67 into google:master Aug 15, 2023
9 checks passed
@r-aramizu
Copy link
Contributor Author

Thank you @gmlewis to review it and help me with this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing important field to find branch in fork from same organization
2 participants