Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of additional endpoints for GitHub Apps. #722

Closed
66 tasks
gmlewis opened this issue Sep 21, 2017 · 5 comments
Closed
66 tasks

Preview of additional endpoints for GitHub Apps. #722

gmlewis opened this issue Sep 21, 2017 · 5 comments

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 21, 2017

GitHub Developer Announcement:
https://developer.github.com/changes/2017-09-21-additional-endpoints-for-github-apps/

Woohoo! Lots of new endpoints to support.

I'm thinking that this is way too big for a single PR, and yet it would probably be silly to open up a separate issue for each endpoint... so how about if I add a checkbox task list to the endpoints in this issue and we can check them off as PRs address them? Obviously, the first PR will also need to add the new custom media type application/vnd.github.machine-man-preview+json in the Accept header and following PRs can just use it.

Here are the recently-added endpoints:

Here are the endpoints for user-to-server requests:

It seems reasonable to assign multiple owners to this issue, and here in the comments we will attempt to clearly document who is working on which endpoints so that we don't waste anyone's time or effort.

Thank you in advance for contributing to this open source project!
Your assistance is greatly appreciated.

@elliott-beach
Copy link
Contributor

I don't think those are new endpoints. I believe the above endpoints are now permissible for GitHub Apps to use, but we already support them for normal API clients. That includes user-to-server requests.

What is new is the machine-man preview header. We might as well add this header to every endpoint listed. I think I can do that in one pull request.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Oct 26, 2017

GitHub follow-on announcement:
https://developer.github.com/changes/2017-10-20-additional-endpoints-for-github-apps/

@elliott-beach - you investigated this previously... thank you! Do you want to take a look and see if this issue can be closed?

@dmitshur
Copy link
Member

A status update here. We had a PR that implemented this issue (at least partially), but deferred merging it because of rationale posted in #736 (review).

Basically, if we wait long enough, this issue will get resolved on its own without us having to make any risky changes (back and forth) in go-github.

If someone really needs this functionality sooner, let us know here so we can make a better informed decision. So, the issue is in waiting/hold status until then.

@dmitshur dmitshur changed the title Support preview Additional endpoints Preview of additional endpoints for GitHub Apps. Dec 15, 2017
@gmlewis
Copy link
Collaborator Author

gmlewis commented Oct 13, 2018

Another GitHub Developer API follow-on announcement:
https://developer.github.com/changes/2018-10-11-new-endpoints-available-for-github-apps/

@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 6, 2021

Closing issue as obsolete.

@gmlewis gmlewis closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants