Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find licenses for k8s.io packages #78

Closed
melinath opened this issue Aug 25, 2021 · 5 comments
Closed

Find licenses for k8s.io packages #78

melinath opened this issue Aug 25, 2021 · 5 comments

Comments

@melinath
Copy link
Contributor

go-licenses is not able to fill the "link for license file" for all go libraries, even if that package's repository is linked on pkg.go.dev and is a supported repository location. For example:

Pkg: k8s.io/utils
License link: https://github.com/kubernetes/utils/blob/master/LICENSE

Currently go-licenses is unable to discover this license link.

@melinath
Copy link
Contributor Author

Note: go-licenses is able to save the license file with go-licenses save

@wlynch
Copy link
Contributor

wlynch commented Aug 27, 2021

Hi! Can you include the command you ran and the output that you got? (partial output for just the k8s.io packages would be okay)

Thanks!

@Bobgy
Copy link
Collaborator

Bobgy commented Aug 31, 2021

IIUC, the most common reason is:

  • you are using go modules
  • you do not vendor your dependencies

then you will hit the "Error discovering URL" problem, because go module cache are not local git folders.
https://github.com/google/go-licenses#error-discovering-url

@Bobgy
Copy link
Collaborator

Bobgy commented Aug 31, 2021

and that's the major reason I raised the v2 proposal which can handle this case properly: #70

@Bobgy
Copy link
Collaborator

Bobgy commented Apr 10, 2022

Already implemented in #94.
Going to be released as v1.1

@Bobgy Bobgy closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants