Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column issues in property-details #14

Closed
pschneider87 opened this issue Dec 13, 2023 · 3 comments
Closed

Column issues in property-details #14

pschneider87 opened this issue Dec 13, 2023 · 3 comments

Comments

@pschneider87
Copy link

Hi @b-kuehn, I discovered an issue I'd like to share.

The feature "list properties" will write the details of the selected properties into the sheet "GA4 Property Details" with Data Retention Duration & Reset User Data on New Activity in Columns Q and R

The "update" function though will use values from columns N (Service Level) and O (Number of Events Over the Past 7 Days) and thus fail.

image

With values for data retention in columns N and O it will work:
image

@b-kuehn
Copy link
Collaborator

b-kuehn commented Dec 28, 2023

Hi,

Thanks for reporting this issue! I forgot to change the column numbers that were referenced in the "update" function for the data retention settings. This should now be fixed in the template sheet.

@b-kuehn b-kuehn closed this as completed Dec 28, 2023
@pschneider87
Copy link
Author

@b-kuehn I just checked with the latest version of your template sheet, and the error still seems to be there. Could you please have a look?

@pschneider87
Copy link
Author

I guess you need to change in new_analytics/modifyGA4Entities as well:

if (ga4Resource == 'properties') { responses.push( updateDataRetentionSettings(entity[16], entity[17], resourceName + '/dataRetentionSettings'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants