Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis support and fix tests on Mono #616

Merged
merged 8 commits into from Nov 6, 2015

Conversation

jtattermusch
Copy link
Contributor

This adds Travis CI support.

-- Adds ReleaseTravis configuration to the solution. ReleaseTravis will build the Release config, but will skip all the Windows and Windows phone projects, which are hard to build on Mono.

-- Adds .travis.yml file and a build script to run all the existing unit tests

-- Some tests are failing under mono because of environment differences (CRLF vs LF line endings) and some implementation differences in standard libraries. This PR provides hotfixes for these failures so that Travis can display a green tickmark.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2015
- nuget install NUnit.Runners -Version 2.6.4 -OutputDirectory testrunner
script:
- mdtool GoogleApisClient.sln # unlike xbuild mdtool skips WindowsPhone projects
- mono ./testrunner/NUnit.Runners.2.6.4/tools/nunit-console.exe Src/GoogleApis.Auth.Tests/bin/Debug/Google.Apis.Auth.Tests.dll

This comment was marked as spam.

@peleyal
Copy link
Collaborator

peleyal commented Oct 16, 2015

Looks awesome!

  1. I still want to read http://docs.travis-ci.com/user/customizing-the-build/ or other docs to understand what's going on.
  2. Did you try to break the tests and then see that if fails?
  3. Will it won't enable merging\submitting code that breaks tests?

Awesome job Jan! 👍

@jtattermusch
Copy link
Contributor Author

Unfortunately, no, I am trying to make it work. Normally, this is easy to setup but this project is harder:

  • travis only supports linux (mono) - and skipping the windows phone projects skipped turns out to be harder.
  • appveyor (there's another pull request for that) is Windows 2012, but for some reason I have trouble getting that works as well.

But yeah, this would be great to have.

@peleyal
Copy link
Collaborator

peleyal commented Oct 17, 2015

Ohhh crap, I didn't see that the latest one is failing.. still adjusting :)

Let me know if I can help...

  • I think that a pull request should be only when you are done, then also we might have be able to see only one commit... But that's for next time.

Thanks!
Eyal

@jtattermusch
Copy link
Contributor Author

There's no way to test this without creating a pull request, that's why I created one. Usually there's a "DO NOT MERGE" label to make this obvious.

@jtattermusch jtattermusch changed the title Try add travis.yml file DO NOT MERGE: Try add travis.yml file Oct 17, 2015
@peleyal
Copy link
Collaborator

peleyal commented Oct 17, 2015

Haaa... I didn't know, sorry
Thanks!

@jtattermusch jtattermusch changed the title DO NOT MERGE: Try add travis.yml file Add travis support and fix tests on Mono Nov 5, 2015
@jtattermusch
Copy link
Contributor Author

Alright, I think I was successful and I finally made this work. Please see PR description for details and review this.

Also note the "continuous-integration/travis-ci/pr" tickmark under "all checks have passed". There's a "Details" link pointing to the console output of the test run. Once this one is merged, the same tick will be displayed for all new pull requests.

.................................................................................................................................................................................................
Tests run: 193, Errors: 0, Failures: 0, Inconclusive: 0, Time: 1.0607255 seconds
Not run: 0, Invalid: 0, Ignored: 0, Skipped: 0

@jtattermusch
Copy link
Contributor Author

I checked and all tests continue to be passing on Windows (so nothing should be broken by the hotfixes).

@peleyal
Copy link
Collaborator

peleyal commented Nov 6, 2015

LGTM. Amazing work Jan!
I'm so happy to you manage to solve it 👍

jtattermusch added a commit that referenced this pull request Nov 6, 2015
Add travis support and fix tests on Mono
@jtattermusch jtattermusch merged commit 96e02a9 into googleapis:master Nov 6, 2015
@peleyal peleyal added this to the 1.10 milestone Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants