Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent package names #78

Closed
bradfitz opened this issue Apr 28, 2015 · 1 comment
Closed

inconsistent package names #78

bradfitz opened this issue Apr 28, 2015 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@bradfitz
Copy link
Contributor

I just noticed we have a few APIs where the version isn't in the normal "vNNN" form:

ante:api $ find -type d | grep _v
./admin/directory_v1
./admin/reports_v1
./admin/email_migration_v2
ante:api $ head admin/directory_v1/admin-gen.go 
// Package admin provides access to the Admin Directory API.
//
// See https://developers.google.com/admin-sdk/directory/
//
// Usage example:
//
//   import "google.golang.org/api/admin/directory_v1"
//   ...
//   adminService, err := admin.New(oauthHttpClient)
package admin

That means you'd import import "google.golang.org/api/admin/directory_v1" but refer to it as admin, which is weird.

Further, https://code-review.googlesource.com/#/c/2370/ proposes adding import "google.golang.org/api/computeaccounts/alpha" imported as computeaccounts, which is even weirder, since it doesn't even have "v" in the final path component.

We should remap these to something cleaner. Like google.golang.org/api/admin/directory/v1 and google.golang.org/api/computeaccounts/v0.alpha perhaps.

/cc @gmlewis

@gmlewis
Copy link
Contributor

gmlewis commented Jul 28, 2015

It looks like v0.alpha was handled in f99e8dd
but we still have weird names in admin which has directory_v1, email_migration_v2 and reports_v1.

@gmlewis gmlewis self-assigned this Jul 28, 2015
gmlewis added a commit that referenced this issue Jul 30, 2015
This fixes issue #78.

Change-Id: I8808c1fe62681a5d914df633c5ac6a7a71a73731
Reviewed-on: https://code-review.googlesource.com/3261
Reviewed-by: Andrew Gerrand <adg@google.com>
@gmlewis gmlewis closed this as completed Jul 30, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants