Updated default issuer #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the default issuer to "https://accounts.google.com" to match the updated issuer value contained in new Google id tokens.
|
This isn't enough, since it will break any google id tokens using the old endpoint. We will actually need to support both strings at the same time. I already have a change made, I just need to bring it into this repo. |
|
This problem was fixed by #982 instead, which allows both the old and the new issuer to function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the default issuer to
https://accounts.google.comto match theupdated issuer value contained in new Google id tokens.
The original
accounts.google.comvalue caused new tokens to fail verification when not setting the issuer manually usingsetIssuer("https://accounts.google.com")