Handle 500 errors that include an error message. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var google = require('../lib/googleapis'); | ||
| var scope = nock('https://www.googleapis.com') | ||
| .post('/urlshortener/v1/url') | ||
| .reply(500, { error: {message: 'There was an error!'}}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| // handle single request errors | ||
| // Consider the response an error if it includes the 'error' property or it has a | ||
| // 500 status code. | ||
| if ((body && body.error) || res.statusCode >= 500) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ryanseys
changed the title
ryanseys
changed the title
|
Updated. |
ryanseys
added a commit
that referenced
this pull request
Feb 11, 2015
Handle 500 errors that include an error message.
|
Thanks! When are you planning to push another version? |
|
Released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360