Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds metadata-flavor header to metadata server ping for compute engine #283

Merged
merged 1 commit into from Jun 26, 2019
Merged

Adds metadata-flavor header to metadata server ping for compute engine #283

merged 1 commit into from Jun 26, 2019

Conversation

freddd
Copy link
Contributor

@freddd freddd commented Jun 26, 2019

Fixes #282

@freddd freddd requested a review from a team as a code owner June 26, 2019 09:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2019
@chingor13 chingor13 self-assigned this Jun 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #283 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
+ Coverage     78.21%   78.24%   +0.03%     
  Complexity      330      330              
============================================
  Files            21       21              
  Lines          1446     1448       +2     
  Branches        157      158       +1     
============================================
+ Hits           1131     1133       +2     
  Misses          237      237              
  Partials         78       78
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 86.33% <100%> (+0.09%) 31 <0> (ø) ⬇️
...tp/java/com/google/auth/oauth2/UserAuthorizer.java 76.57% <0%> (+0.13%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5443a...73f352e. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runningOnComputeEngine is broken when using Workload identities (GKE)
4 participants