Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getCredential(): load credentials with getClient() #648

Merged
merged 2 commits into from Mar 22, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Mar 22, 2019

This change is needed for implementing v4 signed URL. The request that is to be signed needs client_email before calling GoogleAuth.sign(), so we need to change it so that getCredentials() properly loads the credentials.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2019
@jkwlui jkwlui requested a review from a team March 22, 2019 22:28
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #648 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   88.25%   88.39%   +0.14%     
==========================================
  Files          18       18              
  Lines         783      784       +1     
  Branches       86       86              
==========================================
+ Hits          691      693       +2     
+ Misses         80       79       -1     
  Partials       12       12
Impacted Files Coverage Δ
src/auth/googleauth.ts 91.45% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4f99c...4fdd9b7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #648 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   88.25%   88.39%   +0.14%     
==========================================
  Files          18       18              
  Lines         783      784       +1     
  Branches       86       86              
==========================================
+ Hits          691      693       +2     
+ Misses         80       79       -1     
  Partials       12       12
Impacted Files Coverage Δ
src/auth/googleauth.ts 91.45% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4f99c...4fdd9b7. Read the comment docs.

@jkwlui jkwlui merged commit 5cad41a into master Mar 22, 2019
@jkwlui jkwlui deleted the fix-get-credential-get-client branch March 22, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants