Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth token revocation (broken since 0.6.3) #157

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

tadast
Copy link
Contributor

@tadast tadast commented Aug 15, 2018

Looks like https://github.com/google/google-auth-library-ruby/pull/147/files has changed the auth revocation URL from https://accounts.google.com/o/oauth2/revoke to https://oauth2.googleapis.com/revoke and the new URL seems to respond with a 404. This is because /revoke should be invoked with a POST.

Update The HTTP method for /revoke to be a POST.

Looks like 43d175f has updated the API URLs
to follow the updated spec, but the revocation endpoint HTTP method remained
GET whereas it's supposed to be a POST (GET returns 404).

Update The HTTP method for /revoke to be a POST.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 15, 2018
@tadast
Copy link
Contributor Author

tadast commented Aug 15, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 15, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.624% when pulling 3913377 on tadast:fix-token-revocation into 9b49da3 on google:master.

@TheRoyalTnetennba TheRoyalTnetennba merged commit e521abd into googleapis:master Aug 15, 2018
@tadast tadast deleted the fix-token-revocation branch August 21, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants