Ruby auth make scopes optional #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthmgoogle PTAL |
| @@ -76,11 +76,11 @@ def self.determine_creds_class(json_key_io) | |||
| # at http://goo.gl/IUuyuX. | |||
| # | |||
| # If supplied, scope is used to create the credentials instance, when it | |||
| # can applied. E.g, on compute engine, the scope is ignored. | |||
| # can applied. E.g, on google compute engine, the scope is ignored. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Reviewed. Some minor comments. |
|
Changes Unknown when pulling 395febd on tbetbetbe:ruby-auth-make-scopes-optional into * on google:master*. |
tbetbetbe
force-pushed
the
ruby-auth-make-scopes-optional
branch
2 times, most recently
from
4ba3924
to
8cad32e
Compare
- also update CONTRIBUTING.md with more detail
tbetbetbe
force-pushed
the
ruby-auth-make-scopes-optional
branch
from
8cad32e
to
86435f1
Compare
tbetbetbe
added a commit
that referenced
this pull request
Mar 23, 2015
Ruby auth make scopes optional
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.