Add support for a system default credentials file. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path is: - windows: %ProgramData%\Google\Auth\application_default_credentials.json - other: /etc/google/auth/application_default_credentials.json
googlebot
added
the
cla: yes
I have another outstanding PR to fix these; so avoid introducing another one here.
fix failures due to: - misformatting of wrapped lines - a superflous block (and temp dir creation) due to overzealous cut & paste.
|
FYI - coverage decrease is due to not testing the windows? codepath |
|
LGTM fakefs is quite nice, I just added #40 from seeing it used here. |
tbetbetbe
added a commit
that referenced
this pull request
Jul 10, 2015
Add support for a system default credentials file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is: