Base version of 3LO support. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
The RBX failure seems unrelated -- it's crashing when running rubocop. But the cop checks are all clean on other ruby versions. Other people are seeing the same issue and there's already a bug filed with rubinius. |
|
I'm not at Google anymore, but a first read through of this looks pretty solid. No real comments. Nice work! |
|
LGTM |
tbetbetbe
added a commit
that referenced
this pull request
Nov 11, 2015
Base version of 3LO support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submit of 3LO support as multiple PRs. First one is the base user authorizer + token storage, adapted from the google-auth-library-java.
Additional PRs coming for web, installed apps, and Rails support are dependent on this. Preview these in their branches: