Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 0.5 release #54

Merged
merged 5 commits into from
Dec 12, 2015
Merged

Prep for 0.5 release #54

merged 5 commits into from
Dec 12, 2015

Conversation

sqrrrl
Copy link
Contributor

@sqrrrl sqrrrl commented Dec 9, 2015

Updates to release 0.5 for the user authorizer functionality.

Includes updates to tests to use webmock instead of Faraday stubs. Using faraday's stubs turns out to be fragile as data isn't fully normalized (content of env changes depending on the style of the call, even if they're semantically equivalent.) Using webmock ends up being simpler and safer anyway.

…aday stubs (due to fragility -- sensitive to internal changes made in signet)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015
@tbetbetbe
Copy link
Contributor

LGTM - thanks!

@sqrrrl
Copy link
Contributor Author

sqrrrl commented Dec 11, 2015

RBX error appears unrelated (seems a lot of people have issues with rubocop being flakey with rubinius - should just be disabled IMHO)

And not going to sweat a -.06% change in code coverage :)

@tbetbetbe
Copy link
Contributor

LGTM.

rbx-2 should not trigger a failure; I looks like the .travis.yml should stop that, but does not. I think the allow_failures should be:

matrix:
  allow_failures:
    - rvm: rbx-2 # See rubinius/rubinius#3485 - rubocop segfaults

rather than

matrix:
  allow_failures:
    - rbx-2 # See rubinius/rubinius#3485 - rubocop segfaults

Can you add that to this PR and see if it makes a difference ?

@sqrrrl
Copy link
Contributor Author

sqrrrl commented Dec 12, 2015

Thanks, that did the trick.

tbetbetbe added a commit that referenced this pull request Dec 12, 2015
@tbetbetbe tbetbetbe merged commit c75d739 into googleapis:master Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants