Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop warning #98

Merged
merged 6 commits into from Jul 12, 2017
Merged

Fix rubocop warning #98

merged 6 commits into from Jul 12, 2017

Conversation

serihiro
Copy link
Contributor

@serihiro serihiro commented Feb 25, 2017

What will this PR change?

  • fix all rubocop warning to work Travis CI properly
    • All Travis jobs will be failed for rubocop 0.46 warning, for now 馃槺
  • specify ruby 2.3.3 version in travis.yml to fix rvm install error.

before

$ bundle exec rake
Running RuboCop...
Inspecting 33 files
CC...........C..C.C.......C......

after

$ bundle exec rake
Running RuboCop...
Inspecting 33 files
.................................

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2017
@coveralls
Copy link

coveralls commented Feb 25, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.345% when pulling bcca449 on serihiro:fix-rubocop-warning into 37ed189 on google:master.

# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems:
Exclude:
- 'Gemfile'

This comment was marked as spam.

# Configuration parameters: MinBodyLength.
Style/GuardClause:
Exclude:
- 'lib/googleauth/web_user_authorizer.rb'

This comment was marked as spam.

@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.345% when pulling 350de2e on serihiro:fix-rubocop-warning into 37ed189 on google:master.

@hxiong388 hxiong388 merged commit 4cece8b into googleapis:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants