Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not delete wildcard imports #68

Closed
mernst opened this issue Jul 18, 2016 · 1 comment
Closed

Should not delete wildcard imports #68

mernst opened this issue Jul 18, 2016 · 1 comment

Comments

@mernst
Copy link
Contributor

mernst commented Jul 18, 2016

The tool deletes wildcard imports without leaving anything in their place, thus leading to uncompilable code.

Consider this code:

import java.util.*;

class UseList {
  List l;
}

which is transformed to this:


class UseList {
  List l;
}
@cushon
Copy link
Collaborator

cushon commented Jul 18, 2016

Thanks, that's a bad bug in the unused import pass.

(Note that the style guide does not allow wildcard imports, which is probably why it didn't get caught sooner.)

@cushon cushon closed this as completed in dd500c8 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants