Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to clean up usage of GTEST_OS_WINDOWS, _WIN32, and _MSC_VER #35

Closed
GoogleCodeExporter opened this issue Jul 28, 2015 · 2 comments
Closed

Need to clean up usage of GTEST_OS_WINDOWS, _WIN32, and _MSC_VER #35

GoogleCodeExporter opened this issue Jul 28, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link
Contributor 

In the implementation the 3 macros are somehow used interchangeably.  We
should review each use of them and pick the right one:

GTEST_OS_WINODWS for the Windows OS.
_WIN32 for the WIN32 API.
_MSC_VER for the MSVC compiler.

Original issue reported on code.google.com by shiq...@gmail.com on 17 Sep 2008 at 6:58
@GoogleCodeExporter
Copy link
Contributor Author

Original comment by shiq...@gmail.com on 17 Sep 2008 at 6:59

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by zhanyong...@gmail.com on 31 Mar 2009 at 7:42

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter