We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My 2 cents,
GTest
First this CMake install NAMESPACE (GTest) is defined here:
googletest/googletest/CMakeLists.txt
Line 98 in 306f375
Line 105 in 306f375
To use this variable ${cmake_package_name}, it should be defined somewhere else IMHO... Edit: should be defined before including internal_utils.cmake:
${cmake_package_name}
internal_utils.cmake
Lines 90 to 91 in 306f375
gtest
gtest_main
these libraries are defined later using a custom function cxx_library:
Lines 128 to 129 in 306f375
which call cxx_library_with_type:
cxx_library_with_type
googletest/googletest/cmake/internal_utils.cmake
Lines 197 to 203 in 306f375
which call the add_library:
add_library
Lines 147 to 150 in 306f375
add_library(... ALIAS ...)
gmock
gmock_main
pretty the same story:
googletest/googlemock/CMakeLists.txt
Lines 89 to 107 in 7b1cf6d
note gmock CMakeLists.txt include the gtest one
Lines 51 to 55 in 7b1cf6d
note: gmock install rules seems to use an other macro/function:
Line 121 in 306f375
Line 327 in 306f375
Originally posted by @Mizux in #2429 (comment)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
My 2 cents,
GTest
namespaceFirst this CMake install NAMESPACE (
GTest
) is defined here:googletest/googletest/CMakeLists.txt
Line 98 in 306f375
then used here:
googletest/googletest/CMakeLists.txt
Line 105 in 306f375
To use this variable
${cmake_package_name}
, it should be defined somewhere else IMHO...Edit: should be defined before including
internal_utils.cmake
:googletest/googletest/CMakeLists.txt
Lines 90 to 91 in 306f375
gtest
andgtest_main
targetsthese libraries are defined later using a custom function cxx_library:
googletest/googletest/CMakeLists.txt
Lines 128 to 129 in 306f375
which call
cxx_library_with_type
:googletest/googletest/cmake/internal_utils.cmake
Lines 197 to 203 in 306f375
which call the
add_library
:googletest/googletest/cmake/internal_utils.cmake
Lines 147 to 150 in 306f375
so we should try to add the
add_library(... ALIAS ...)
to this function IMHOgmock
andgmock_main
targetspretty the same story:
googletest/googlemock/CMakeLists.txt
Lines 89 to 107 in 7b1cf6d
note gmock CMakeLists.txt include the gtest one
googletest/googlemock/CMakeLists.txt
Lines 51 to 55 in 7b1cf6d
note: gmock install rules seems to use an other macro/function:
googletest/googlemock/CMakeLists.txt
Line 121 in 306f375
defined here (EDIT: just adding targets to the googletest target):
googletest/googletest/cmake/internal_utils.cmake
Line 327 in 306f375
(ed notice the of variable ${targets_export_name})
Originally posted by @Mizux in #2429 (comment)
The text was updated successfully, but these errors were encountered: